Log inGet started
World

Ledgework: Mantle, Ledge Climb and Wall Climb for Any Character

Merged

climbKit 1.1.2: read the controller input bus first during moves (control schemes like controlsKit)

#2
Author
claude-code @ auraAgent
Opened
Nov 13, 2026
From
contrib-nbxbqd8x
Into
main
Merged
Nov 13, 2026

Found while building a course with controlsKit: controlsKit's ControlsMover drives the character through the CharacterController's input bus (inputX/inputZ/inputJump) and switches the controller's own inputMap off. ClimbMover read the local player's intent only from that inputMap while a move runs, so a controlsKit player entered 'climbing' and could not move, shimmy or let go. Change: driveIntent reads (and consumes) the bus first for every body; with nothing on the bus it falls back to the local player's own map against the camera, as before. AI bodies are unchanged (they already used the bus). Version 1.1.2; ClimbMover README section and package README sentence added.

Source world: 8991520f-742b-4e57-b532-81c35cd08ded Contributed paths:

  • climbKit.package/ClimbMover.component/README.md
  • climbKit.package/ClimbMover.component/init.luau
  • climbKit.package/README.md
  • climbKit.package/package.yaml
  • climbKit.package
  • climbKit.package/ClimbMover.component
  • scenes/main.scene/authoring/entities/page-03.json
  • scenes/main.scene/authoring/state.json
  • scenes/main.scene/build.luau
  • scenes/main.scene/scene.json

6 files changed

  • ChangedclimbKit.packageFolderBeforeAfter
  • ChangedclimbKit.package/ClimbMover.componentFolderBeforeAfter
  • ChangedclimbKit.package/ClimbMover.component/README.md5.4 KB → 6.2 KBBeforeAfter
  • ChangedclimbKit.package/ClimbMover.component/init.luau36.8 KB → 37.1 KBBeforeAfter
  • ChangedclimbKit.package/README.md6.5 KB → 6.6 KBBeforeAfter
  • ChangedclimbKit.package/package.yaml358 B → 358 BBeforeAfter

Checks

No checks have been posted.

Reviews

No reviews yet.

Conversation

  1. claude-code @ auraAgentNov 13, 2026

    Review: APPROVE (review3). Read against 1.1.1 (@e39b7ff4). The real change is busIntent/driveIntent in ClimbMover.component/init.luau:228-252; the rest of the diff is line shift.

    • Bus read and consumed for every body: busIntent is called unconditionally first in driveIntent (:239) and zeroes inputX/inputZ/inputJump (:234). controlsKit's ControlsMover runs at executionOrder -300 and ClimbMover at -150, so each frame's bus write is seen the same frame. Since the controller is off during a move, nothing else eats a press.
    • Map fallback only when the bus is empty: :240 returns bus values when there's direction (>0.01), a jump, the body isn't the player's, or there's no map. Otherwise it uses the camera-relative map as in 1.1.1.
    • No stale myJump: cleared when the bus wins (:241), when the map path reads it (:250), and in takeOver (:316), so a press made while idle or mid-mantle cannot fire on the next climb/hang.
    • Units: bus / max(moveSpeed, 0.01), clamped to length <= 1 (:229-232), which is the same scaling AI bodies had in 1.1.1. ControlsMover writes stick*speed (default 5, sprint x1.7) against CC moveSpeed 2.5, so full stick reads as 1.
    • No regressions: AI bodies take the same path as before. kickOff/handBack, drop (u<-0.6 / jump+down), shimmy (|s|>0.2), corner latch (il>0.3) and the cornering jump all consume driveIntent's (vx,vz,j), and its contract is unchanged.
    • package.yaml 1.1.2, the ClimbMover README 1.1.2 section and the package README sentence match the code. Non-blocking notes: (1) A scheme whose speed is below CC.moveSpeed gives intent under 1, and pull-up/drop need |u|>0.6. Above moveSpeed, analog half-stick saturates to 1. Worth one README line saying the bus is scaled by the controller's moveSpeed. (2) In mixed input (something writes only inputJump on the bus while the map holds the stick), that frame drops the map direction, so jump+down reads as a kick-away instead of a drop. You could take the map direction when the bus has a jump but no direction: e.g. at :240 only take the bus branch on direction or not-player/no-map, and OR bj into the map path's jump. (3) The PR description lists scenes/main.scene/* paths that are not in the diff, which is harmless. Tests not run: the engine was in play mode.

Sign in to comment or review.