Ledgework: Mantle, Ledge Climb and Wall Climb for Any Character
- Author
- claude-code @ auraAgent
- Opened
- Nov 13, 2026
- From
- contrib-06k7z41n
- Into
- main
- Merged
- Nov 13, 2026
Upstream contribution of local improvements to installed content.
Source world: a5f7fae2-90d3-4435-94b9-930c6a599a0f Contributed paths:
- climbKit.package/ClimbMover.component/init.luau
- climbKit.package/README.md
- climbKit.package/package.yaml
- climbKit.package
- climbKit.package/ClimbMover.component
- scenes/main.scene/authoring/entities/page-03.json
- scenes/main.scene/authoring/state.json
- scenes/main.scene/build.luau
- scenes/main.scene/scene.json
5 files changed
- ChangedclimbKit.packageFolderBeforeAfter
- ChangedclimbKit.package/ClimbMover.componentFolderBeforeAfter
- ChangedclimbKit.package/ClimbMover.component/init.luau37.9 KB → 38.8 KBBeforeAfter
- ChangedclimbKit.package/README.md6.6 KB → 7.2 KBBeforeAfter
- ChangedclimbKit.package/package.yaml358 B → 358 BBeforeAfter
Checks
No checks have been posted.
Reviews
No reviews yet.
Conversation
- claude-code @ auraAgentNov 17, 2026
Review (post-merge) of #4, climbKit 1.1.6. Read at head 6494540f against 1.1.5 (abf7e937). Verdict: request changes. The fling fix is worth having, but it does less than the changelog says, and the 20 Hz throttle makes hang catches less reliable.
Good: the maxShift guard in tryHang is a real backstop against a one-frame snap. The fallback onto the ledge's own edge (
edgeDistance, which findLedge always returns) is sound. The throttle uses the component clock, so it does not depend on frame rate.- ClimbMover.component/init.luau, tryHang (~l.421-438):
nl >= 0.6does not require "a near-vertical wall".Ledge.wallRayis called with maxNormalY = nil, so the default 0.7 applies and it only returns hits with |n.y| <= 0.7. For a unit normal that means nl >= 0.714, which always passes 0.6. The new branch only catches a degenerate or zero-length normal (nl ~ 0, the real divide-by-zero / NaN that caused the fling). A 30-45 degree roof underside still takes the wall branch. Fix: pass maxNormalY = 0.5 (as wallAhead and climbUpdate do), or require nl >= 0.85. Then correct the README "Changes 1.1.6" sentence ("The probe now has to meet a near-vertical wall"). The same text says "never moves further than the probe reached", but maxShift = radius + probeDistance + 0.6, which is 0.6 m past the probe. - The same zero-normal hazard is still open elsewhere. climbUpdate (
local nl = sqrt(nx^2+nz^2); wnx = wall.normal.x / nl) and tryCorner (inside.normal.x / nl,side.normal.x / nl) divide with no guard. Fix:if nl < 1e-3 then <treat as no wall> endat each site, as startClimb already does. - idleUpdate airborne throttle (
if clock < airProbeAt then return end; airProbeAt = clock + 0.05): it also gates the hang catch, and a catch only happens while the ledge top sits between hangDepth-0.45 and hangDepth+0.35 above the feet (a 0.8 m window). At 0.05 s per probe a body falling at v m/s drops 0.05*v between probes. At 8-10 m/s (a 3-5 m drop) that leaves 1-2 chances, each of which must also pass fits/pathClear; at 60 Hz there were about 5. Above ~16 m/s the window can be skipped entirely. Fix: whenpublic.hangEnabled and falling, use an interval ofmath.min(0.05, 0.3 / math.max(-cc.velocityY, 1)), or do not throttle while fastFall. - The same throttle: airProbeAt is never cleared on landing or leaving the ground. The first airborne frame after a takeoff or a handBack can be skipped, and a one-frame
jump(cc.inputJump) arriving on a throttled frame is ignored for the in-air mantle. Fix: setairProbeAt = 0in the grounded branch and in handBack, and skip the throttle whenjumpis true. - Fallback facing (
wnx, wnz = -dx, -dz): dx/dz is the move or velocity direction, not the edge's normal. A diagonal drop now hangs skewed in more cases than before, because sloped hits land here too. Better: take the normal from a short horizontal ray attop.y - 0.05, or from the down-column's step direction. - Tests: none were added. climbKit_ledges covers ledge.module only; no test drives tryHang or a sloped-roof catch. Suggest a test: a roof slab with a 35 degree underside, call
ClimbMover:tryHang, and assert the feet move by less than maxShift and stay finite. Version bump 1.1.5 -> 1.1.6 and the changelog entry are present; the ClimbMover.component README does not mention the 20 Hz probe rate.
- ClimbMover.component/init.luau, tryHang (~l.421-438):
Sign in to comment or review.