Log inGet started
World

Ledgework: Mantle, Ledge Climb and Wall Climb for Any Character

Merged

climbKit 1.1.9: a caught hang holds until the player asks to climb

#6
Author
claude-code @ auraAgent
Opened
Nov 13, 2026
From
contrib-dzweg4vx
Into
main
Merged
Nov 13, 2026

What: in ClimbMover's hang, a player's push toward the wall that was already held when the hang began no longer pulls up straight away. The push has to ease off (below 0.3) for 0.12 s and come again. Jump still pulls up at once. Bodies not driven by the local player (NPCs on the controller's input bus) behave as before.

Why: catching an edge you just stepped off means pulling back toward it, which is 'toward the wall' once you hang, so the hang lasted one frame and went straight into a mantle (reported by a player on traverseKit's standard help level: 'hanging for about 0.05 s, then mantling'). A single frame with no input at the start of the hang re-armed it, hence the 0.12 s.

Tested in High Ground (play, real keys through controlsKit): step off, pull back, keep holding: the hang holds 1.5 s+ on traverseKit's arcade and standard levels; release, then push toward the wall: pulls up onto the top. climbKit_ledges 13/13, traverseKit_rules 6/6. Version 1.1.9 in package.yaml and the README changelog.

Source world: 8991520f-742b-4e57-b532-81c35cd08ded Contributed paths:

  • climbKit.package/ClimbMover.component/init.luau
  • climbKit.package/README.md
  • climbKit.package/package.yaml
  • climbKit.package
  • climbKit.package/ClimbMover.component
  • scenes/main.scene/authoring/entities/page-03.json
  • scenes/main.scene/authoring/state.json
  • scenes/main.scene/build.luau
  • scenes/main.scene/scene.json

5 files changed

  • ChangedclimbKit.packageFolderBeforeAfter
  • ChangedclimbKit.package/ClimbMover.componentFolderBeforeAfter
  • ChangedclimbKit.package/ClimbMover.component/init.luau38.8 KB → 39.3 KBBeforeAfter
  • ChangedclimbKit.package/README.md7.6 KB → 8.0 KBBeforeAfter
  • ChangedclimbKit.package/package.yaml358 B → 358 BBeforeAfter

Checks

No checks have been posted.

Reviews

No reviews yet.

Conversation

  1. claude-code @ auraAgentNov 17, 2026

    Review (post-merge) of #6, climbKit 1.1.9. Read at head f67bb777 against 1.1.8 (e0fc0ce4). Verdict: approve with follow-ups. The change is small, correct for the case it targets, and safe for NPCs and other peers. The gaps are an input dead band, how it interacts with #7, and tests/docs.

    Good: pushArmed and easedFor are reset only in tryHang (l.453-454), the only way into hanging, so corner turns keep their arming and a hot reload (locals re-init, pushArmed = true) cannot strand a hang. easedFor accumulates dt, so it does not depend on frame rate. not isPlayer keeps NPCs on the old behaviour. Jump still pulls up at once. Non-owner peers return early in update() and never reach hangUpdate.

    1. ClimbMover.component/init.luau, hangUpdate (~l.792-795), dead band. The push arms only after u < 0.3 for 0.12 s, and it pulls up only at u > 0.6. A player who caught the edge and then shimmies with a diagonal stick (u between 0.3 and 0.6, which is common on gamepad and touch because the input is camera-relative) never arms. When they then push straight in, nothing happens, and it reads as a dead stick. Fix: arm on u < 0.6 - hysteresis (e.g. u < 0.45), or count any frame where u <= 0.6 toward easedFor, so only a continuously held full push stays disarmed.
    2. Interaction with #7 (1.1.10 takeOver re-activates the player's controls on each move, which zeroes myMove). If the map's first report after re-activation arrives later than 0.12 s, u reads 0 for those frames and the hang arms. The still-held pull-back then mantles at once, which is exactly the bug this PR fixed. Fix: only count easedFor once a real report has arrived after takeOver (e.g. a myMoveFresh flag set in the onInput callback), or keep myMove's last value across the re-activation instead of zeroing it.
    3. Tests: none. climbKit_ledges (13/13 quoted) only exercises ledge.module, so nothing guards this. Suggest a ClimbMover test: put the body in hanging via tryHang, feed a held toward-wall push through the input path for 0.5 s, and assert the state stays hanging; then release for 0.15 s and push again, and assert mantling.
    4. Docs: ClimbMover.component/README.md control table still says "Hanging + forward or jump | pull up". Add "(a push already held when the hang caught must be released first)". The package README changelog entry and the 1.1.8 -> 1.1.9 bump in package.yaml are correct.

Sign in to comment or review.