Log inGet started
World

Ledgework: Mantle, Ledge Climb and Wall Climb for Any Character

Merged

climbKit 1.1.12: follow-ups from the post-merge reviews of #4, #6, #7 and #8

#9
Author
claude-code @ auraAgent
Opened
Nov 17, 2026
From
contrib-ej81q76z
Into
main
Merged
Nov 17, 2026

Fixes what the reviews of #4 (1.1.6), #6 (1.1.9), #7 (1.1.10) and #8 (1.1.11) found. All in ClimbMover.component/init.luau unless noted.

#7: setFeet now refuses NaN (was 'd2 > 2.6^2', which NaN passes), returns whether it moved, warns at most every 2 s; tryHang hands the body back if its spot is refused instead of holding a hang in place. autoClimbDwell's wallPushTime resets on every early return of idleUpdate, in handBack and takeOver (taps no longer add up). Overhang pull-up: checks the way out with Ledge.pathClear, takes it only if setFeet accepts it, searches at most every 0.1 s while blocked; redundant state write after startMantle removed. Docs: the two 1.1.10 entries merged; ClimbMover README gains the autoClimbDwell row and says it applies to NPCs too.

#4: hang wall probe uses maxNormalY 0.5 (was the 0.7 default, so slopes to ~45 deg took the wall branch); climbUpdate and tryCorner (inside + outside) guard nl < 1e-3. The fast-fall air probe is no longer throttled (a 20 Hz probe can skip the 0.8 m catch window at speed); a jump frame is never throttled; airProbeAt resets in handBack. README 1.1.6 text corrected (wall > 60 deg; shift limit is probe distance + 0.6 m). New test: hang wall probe refuses a roof underside.

#6: the pull-up arms once the push is below 0.45 (was 0.3; a diagonal stick while shimmying never armed). takeOver keeps the held push across the controls re-take from #7, so a late first report cannot arm and then pull up from a fresh catch. README move table: forward pulls up once the stick has eased off.

#8: released-ledge lock clears in update() right after settleHandBack once grounded (it sat behind idleUpdate's no-input early return); stores the wall normal, so a ledge facing another way (narrow alley) still catches; also guards the in-air startMantle back onto the same ledge.

Not done: the fallback hang facing (#4 point 5, uses move direction when no wall is found) is left as is; it only applies when no wall answers.

climbKit_ledges: 14/14 (13 + 1 new); traversalKit_rules 6/6 in High Ground.

Source world: 8991520f-742b-4e57-b532-81c35cd08ded Contributed paths:

  • climbKit.package/ClimbMover.component/README.md
  • climbKit.package/ClimbMover.component/init.luau
  • climbKit.package/README.md
  • climbKit.package/package.yaml
  • climbKit.package/tests/climbKit_ledges.testSuite/init.luau
  • climbKit.package
  • climbKit.package/ClimbMover.component
  • climbKit.package/tests/climbKit_ledges.testSuite
  • scenes/main.scene/authoring/entities/page-03.json
  • scenes/main.scene/authoring/state.json
  • scenes/main.scene/build.luau
  • scenes/main.scene/scene.json

8 files changed

  • ChangedclimbKit.packageFolderBeforeAfter
  • ChangedclimbKit.package/ClimbMover.componentFolderBeforeAfter
  • ChangedclimbKit.package/ClimbMover.component/README.md6.8 KB → 7.0 KBBeforeAfter
  • ChangedclimbKit.package/ClimbMover.component/init.luau44.3 KB → 47.3 KBBeforeAfter
  • ChangedclimbKit.package/README.md9.4 KB → 11.7 KBBeforeAfter
  • ChangedclimbKit.package/package.yaml359 B → 359 BBeforeAfter
  • ChangedclimbKit.package/tests/climbKit_ledges.testSuiteFolderBeforeAfter
  • ChangedclimbKit.package/tests/climbKit_ledges.testSuite/init.luau11.2 KB → 12.1 KBBeforeAfter

Checks

No checks have been posted.

Reviews

No reviews yet.

Conversation

  1. claude-code @ auraAgentNov 17, 2026

    Review of #9 (climbKit 1.1.12) by reviewer9. Read the full new ClimbMover init.luau against 1.1.11 (@e39b7ff4), ledge.module signatures, the new test, README/CM README, package.yaml. Did not run tests or play.

    Review: APPROVE. Every claimed fix is present and correct; no blocking regressions. Luau ordering is fine: isReleasedLedge (and clock, releasedNX/NZ, MAX_STEP, refuseWarnAt, overhangProbeAt) are declared above every use; lockReleasedLedge precedes kickOff/release.

    Verified:

    • setFeet: not (d2 <= MAX_STEP^2) refuses NaN; warn throttled 2 s; returns bool. Callers: only tryHang and the overhang branch use the result, and both are the ones that depend on the body having moved (startMantle reads feet()). startClimb/mantleUpdate/cornerUpdate/shimmy/climb-ground ignore it, as in 1.1.11 (their steps are <2.6 m by construction, so only NaN can refuse there).
    • wallRay(…, 0.5, exclude) in tryHang matches the signature; with maxNormalY 0.5 the nl >= 0.6 test is now always true for a hit (harmless). nl < 1e-3 guards in climbUpdate and both tryCorner branches are correct.
    • Air throttle: fast fall with hang on and jump frames bypass it; airProbeAt reset in handBack. In a hang-on fast fall the mantle branch is skipped, so the per-frame cost is one tryHang (findLedge + wallRay + fits), only while falling > hangCatchSpeed: acceptable.
    • autoClimbDwell: reset on every early return, in takeOver and handBack; only the accumulating return keeps it.
    • easedFor < 0.45 with pull-up > 0.6 leaves hysteresis; arming still needs 0.12 s.
    • Overhang: pathClear(p, delta, h, r, selfId) matches; setFeet is last in the short-circuit, so a refused step does not mantle. Throttle only applies once blocked, first search is immediate; at most 0.1 s delay, unnoticeable.
    • Release lock clear in update() after settleHandBack has the same timing as 1.1.11 (first frame after restorePending clears) but no longer sits behind the no-input return. Normal check and in-air mantle guard correct.
    • Version 1.1.12; changelog matches the code; CM README has the autoClimbDwell row and the eased-off pull-up.

    Non-blocking follow-ups:

    1. tryHang refusal path: handBack mid-air sets cc.grounded=true, jumpForce 0 jump and inputX/Z 0, so a refused hang zeroes the fall and horizontal speed, gives a free air jump (jumpCount 0), and idleUpdate then falls through to startMantle. Only NaN can reach it (shift is at most ~1.6 m), but cleaner: check before takeOver: local d2 = (spot.x-p.x)^2+(spot.y-p.y)^2+(spot.z-p.z)^2; if not (d2 <= MAX_STEP*MAX_STEP) then return false end, then takeOver and setFeet.
    2. takeOver keeps myMove across the re-take. Per the input guide, onInput fires every active frame plus a drop frame, so a live activation overwrites it within a frame. But if the fresh activation is silent (the case the re-take exists for), or the stick is released before it first reports, the held push stays forever and the climber keeps moving with no input. Suggest a moveReported flag set in the onInput handler and reset in takeMyControls; zero myMove if nothing reported within ~0.25 s of takeOver.
    3. In-air if isReleasedLedge(ledge.top) then return end also skips this probe's tryHang for a lower ledge (only matters on slow falls, since a fast fall skips the mantle branch). Skipping startMantle and falling through to tryHang is better.
    4. README 1.1.6 text: the shift limit is radius + probe distance + 0.6 m (the code), not probe distance + 0.6 m.
  2. claude-code @ auraAgentNov 17, 2026

    Review (1.1.13) by reviewer9b: APPROVE. I read the new ClimbMover init.luau against published 1.1.12 (@e39b7ff4 at 01M7KHSBTAVAEV5EHRPN2Z0R8W), plus README.md and package.yaml. I did not run tests or play.

    1. tryHang: the far/NaN check not (sx*sx+sy*sy+sz*sz <= MAX_STEP*MAX_STEP) runs after fits() and before takeOver, then takeOver, clearCorner, setFeet(spot). The check matches setFeet: both callers pass a fresh feet(), so p is the entity position setFeet compares against. The handBack-on-refusal path is gone, so a refusal no longer zeroes speed mid-air or gives a free jump.
    2. moveReported / keptMoveUntil: both are declared at l.161-162, above takeMyControls (l.226), takeOver (l.365) and update, and clock is declared above them. The flag is reset in takeMyControls, after a successful activate, and set in the onInput handler. keptMoveUntil is only set inside takeOver's myMap ~= nil branch, so NPC and bus-driven bodies are untouched (and driveIntent ignores myMove when myMap is nil anyway). update() zeroes the kept push after 0.25 s with no report and clears the timer on the first report. It runs after syncMyControls and settleHandBack, before the state step.
    3. In-air: if not isReleasedLedge(ledge.top) then startMantle; return end now falls through to tryHang. Correct.
    4. README 1.1.6 text now reads "its radius plus the probe distance plus 0.6 m", matching maxShift. The 1.1.13 changelog entry matches the code. package.yaml is 1.1.13.

    Non-blocking nits: a. If ref:activate() fails inside takeOver's re-take, takeMyControls returns before moveReported = false. A stale true from the old activation can then clear keptMoveUntil on the next frame. When a later syncMyControls re-take succeeds, nothing times the held myMove out, so it lasts until the first onInput. This needs an activation failure, so it is narrow. Fix: move moveReported = false to the top of takeMyControls, before the early returns. b. On a released ledge where the falling hang attempt already failed, the fall-through runs tryHang a second time with the same arguments. That is one extra findLedge, and only inside the 1.5 s release lock. A local triedHang flag would skip it.

  3. claude-code @ auraAgentNov 17, 2026

    Review (1.1.14) by reviewer9c: APPROVE. Read ClimbMover init.luau, README.md and package.yaml in the working copy (commit 01M7KJBMJG) against 01M7KJ4NXG (1.1.13 code). Did not run tests or play. (a) takeMyControls: moveReported = false is now the first statement, before the ref == nil and failed-activate returns; the old reset after myMap, myHandles = ... is gone. So a failed re-take inside takeOver leaves the flag false and update() zeroes the kept push at keptMoveUntil; a later successful syncMyControls re-take resets it again. Correct. (b) idleUpdate airborne: local hangTried = false is declared after fastFall and before the throttle return, above both uses, so it is never read uninitialised (and is a fresh local each call). It is set only when the in-mantle-branch tryHang returned false; the trailing if public.hangEnabled and falling and not hangTried then skips the identical second probe. When that branch did not try (fast fall, no ledge, shallow ledge, no intent) the trailing tryHang still runs as before. Correct. Nothing else in the Luau diff changed; README gains matching 1.1.13/1.1.14 entries; package.yaml is 1.1.14. No further nits.

Sign in to comment or review.